fix(DropdownMenu): performance issue 228

Removes the callto scheduleUpdate and only renders the Popper if show prop is true Fixes #228
tabler · Jun 14, 2018 · 7a6a9f7 · 7a6a9f7
1 parent 5e0fbc5
commit 7a6a9f7
Showing 1 changed file with 17 additions and 16 deletions.
diff --git a/src/components/Dropdown/DropdownMenu.react.js b/src/components/Dropdown/DropdownMenu.react.js
@@ -41,7 +41,7 @@ function DropdownMenu({
   arrowPosition = "left",
   style,
   rootRef,
-  show,
+  show = false,
 }: Props): React.Node {
   const classes = cn(
     {
@@ -53,21 +53,22 @@ function DropdownMenu({
     className
   );
   return (
-    <Popper placement={position} eventsEnabled={true} positionFixed={false}>
-      {({ ref, style, placement, scheduleUpdate }: PopperChildrenProps) => {
-        scheduleUpdate();
-        return (
-          <div
-            className={classes}
-            data-placement={placement}
-            style={style}
-            ref={ref}
-          >
-            {children}
-          </div>
-        );
-      }}
-    </Popper>
+    show && (
+      <Popper placement={position} eventsEnabled={true} positionFixed={false}>
+        {({ ref, style, placement }: PopperChildrenProps) => {
+          return (
+            <div
+              className={classes}
+              data-placement={placement}
+              style={style}
+              ref={ref}
+            >
+              {children}
+            </div>
+          );
+        }}
+      </Popper>
+    )
   );
 }