Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PhoneInput): add tkv3 phone input #140

Draft
wants to merge 2 commits into
base: next
Choose a base branch
from
Draft

feat(PhoneInput): add tkv3 phone input #140

wants to merge 2 commits into from

Conversation

wahidfarid
Copy link
Contributor

@wahidfarid wahidfarid commented Oct 12, 2022 •
edited
Loading

Todo list (not exhaustive):

  • port over flag from tkv2 + flag asset
  • props specific to phone input
  • implement select for flags/area codes (probably from a fresh perspective. porting over TKv2 stuff has proven overly complicated and cumbersome

Completes #111

@netlify
Copy link

netlify bot commented Oct 12, 2022 •
edited
Loading

❌ Deploy Preview for tablekit failed.

Name Link
🔨 Latest commit 7fbcaab
🔍 Latest deploy log https://app.netlify.com/sites/tablekit/deploys/636a0fed155b1b00081ee867

@github-actions
Copy link

github-actions bot commented Oct 12, 2022 •
edited
Loading

Unit Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 25ab57a. ± Comparison against base commit 89685b1.

♻️ This comment has been updated with latest results.

@wahidfarid wahidfarid force-pushed the 111#phone-input branch 2 times, most recently from 25ab57a to e3f6b1b Compare November 1, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wahidfarid wahidfarid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wahidfarid