Elixir Version Improvements #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@joseph-lozano is attempting to deploy a commit to the Theo's projects Team on Vercel. A member of the Team first needs to authorize it. |
joseph-lozano
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also renamed to global_setup file to match the module name and added a unique index for the Pokemon dex id
When running with MIX_ENV=dev you won't notice the effects of moving things into priv/static, when when you when the release (specifically mix phx.digest, which is already in the Dockerfile), then you will noticed that all images are cached.
For the turbo, let's just load all the images upfront, instead of the only the next 2