Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crypto not defined in cli envVars.ts. t3-oss/create-t3-app#2009 #2010

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

swyckoff
Copy link
Contributor

@swyckoff swyckoff commented Nov 3, 2024

Closes #2009

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Added the import of crypto from 'node:crypto' to envVars.ts


Screenshots

[Screenshots]

💯

Copy link

vercel bot commented Nov 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2024 9:58pm

Copy link

vercel bot commented Nov 3, 2024

@swyckoff is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global crypto should be available for most modern node versions (especially LTS+) but i guess we can add this to support even older ones

please add chacngest then i can merge and releas

Copy link

changeset-bot bot commented Nov 3, 2024

🦋 Changeset detected

Latest commit: 902a5cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swyckoff
Copy link
Contributor Author

swyckoff commented Nov 3, 2024

global crypto should be available for most modern node versions (especially LTS+) but i guess we can add this to support even older ones

please add chacngest then i can merge and releas

Done!

@juliusmarminge juliusmarminge merged commit 12fccae into t3-oss:main Nov 4, 2024
266 of 267 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Crypto not defined in envVars cli installer
2 participants