-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CLI up-to-date #2007
base: main
Are you sure you want to change the base?
Make CLI up-to-date #2007
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@ahkhanjani is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
The new ESLint installer could works by:
Note: At the moment we're not reading the CLI's generated Prettier config. We could do that and we'd get a more accurate formatting. I'm not sure if we could apply the Prettier plugins though (e.g. @ianvs/prettier-plugin-sort-imports) so we'll have to handle the order of the |
I don't understand the linting errors we're getting |
@juliusmarminge drizzle needs updating. Any breaking changes I need to know of? |
I think we should upgrade tsup as well while we're at it |
The only breaking changes between major versions 6 to 7 to 8 seems to be node version support drops so I'll just bump the version. |
@juliusmarminge I think we're only pending on drizzle. |
since we're writing to fs without formatting on error, we should be as good looking as possible by default
Hey @ahkhanjani, thank you for your work on this! I'm just curious as to whether you know if this is on Drizzle's roadmap? I saw the issue you linked to their repo, but it seems that hasn't had any activity since. |
I appreciate your words.
I don't remember the issue you're mentioning. Can you send the link here? |
@juliusmarminge Why are we not merging btw? |
Oh, apologies, I thought you had linked the issue but I had actually found it myself. The issue is drizzle-team/drizzle-orm#2491 There's an issue with Drizzle about supporting the new flat config, which forgive me if I'm wrong since I've not looked into the ESLint 8 to 9 migration, is what I thought you meant about waiting for Drizzle? (quick note to also mention that I've only just seen your later commit to update Drizzle which could be what you had meant you was waiting for) |
Closes #
✅ Checklist
Changelog
[Short description of what has changed]
Screenshots
[Screenshots]
💯