Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added a condition, if docker is alive or not. #1983 #1984

Closed
wants to merge 2 commits into from

Conversation

Sapython
Copy link

@Sapython Sapython commented Sep 19, 2024

This caused problems when docker was not running which resulted in the CLI misinforming me that the database was already running. But it wasn't.

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

[Short description of what has changed]
Added a simple condition to run docker info to check if the docker daemon is actually running or not.

Screenshots

[Screenshots]
image

In this image you can see that the both of the execution of start-database.sh are successful. But the second one should fail because I killed the docker daemon but the CLI wasn't able to pick it up.
💯

This caused problems when docker was not running which resulted in the CLI misinforming me that the database was already running. But it wasn't.
Copy link

changeset-bot bot commented Sep 19, 2024

⚠️ No Changeset found

Latest commit: 4c0b925

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 1 unresolved
✅ 1 resolved
Sep 19, 2024 2:57pm

Copy link

vercel bot commented Sep 19, 2024

@Sapython is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@Sapython Sapython changed the title Added a condition, if docker is alive or not. #1983 fix: Added a condition, if docker is alive or not. #1983 Sep 19, 2024
@juliusmarminge
Copy link
Member

Closed by #1975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants