Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scopedAppName for env #1942

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

AbiramK
Copy link
Contributor

@AbiramK AbiramK commented Jul 10, 2024

Closes #1919

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Fixes for #1919
Changes involves using scopedAppName instead of projectName on creation of env files


Screenshots

image
image

💯

Copy link

changeset-bot bot commented Jul 10, 2024

⚠️ No Changeset found

Latest commit: dcdd8db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 6:34am

Copy link

vercel bot commented Jul 10, 2024

@AbiramK is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@AbiramK AbiramK changed the title fix: scopedAppName for env #1919 fix: scopedAppName for env Jul 10, 2024
@juliusmarminge juliusmarminge merged commit 300ce09 into t3-oss:main Jul 10, 2024
265 of 267 checks passed
@AbiramK AbiramK deleted the fix/dot_env_#1919 branch July 10, 2024 07:23
@lem0n4id
Copy link

@AbiramK Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: using dot name doesn't automatically fill the dir name in .env file
3 participants