fix: start-database.sh CONTAINER_NAME update with '.' project name (#1834) #1871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1834
✅ Checklist
Changelog
NOTE: I was messing with my forked repo and accidentally closed the original pr because of a rebase of the main branch.
The dbContainer.ts file in cli/src/installers/dbContainer.ts was updated with a parseNameAndPath function when a projectName of "." was used. This was done with a ternary and destructuring to keep the type safety of the variable.
I had a few options.
I decided to go with the last route because it's a single source of truth and can be used for future implementations.
I followed the data flow of projectName and scopedProjectName through and through and couldn't find a solution.
Then I tried a few other things to see If I could make this feel less hacky but to no avail.
Screenshots
[Screenshots]
💯