-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use trpc 11 #1741
feat: use trpc 11 #1741
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
🦋 Changeset detectedLatest commit: 09119f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://create-t3-app-git-trpc11-t3-oss.vercel.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr looks good. how do you feel about merging while trpc v11 is still in beta? from what i understand APIs/interfaces aren't guaranteed to be stable (in terms of semver) yet?
always a fine line to draw... I'm okay merging it cause I can easily make any necessary updates to the template if necessary. Although I guess people initting might not feel the same... I'm exclusively using v11 right now, and Alex and Nick are using it at work, but I understand we're special cases 🫣 |
@@ -6,7 +6,7 @@ import { api } from "~/trpc/server"; | |||
|
|||
export default async function Home() { | |||
noStore(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does noStore()
still required after the change of src/trpc/server.ts
? Removing it no longer cause dynamic-server-error when next build
Is there a way to use this without being merged? Thank you |
A new create-t3-app prerelease is available for testing. You can install this latest build in your project with: pnpm create [email protected] |
@juliusmarminge is there a goal for when this will get merged? Asking simply because not sure if we will be waiting for trpc to exit beta before its merged - in which case I won't wait for it and will adopt this PR manually in my project :) |
Is there a plan or maybe an ETA for this? I've basically copied the changes into my codebase :D Maybe a waaay of crazy question but maybe a dedicated branch for all the crazy beta unstable stuff? Since Auth.js is also in experimental mode ( and I already went on latest with it ). Cheers and regards from Austria. |
Good question. Both TRPC 11 and Next Auth 5 (Auth.js) are coming out over the next several weeks. Meanwhile, Prisma has released a new serverless edge driver for Neon.tech and Planetscale. |
Not sure why prisma is mentioned here.I am using the latest of everything… auth 5, trpc 11, react-query 5… all is good , been using this PR |
This'll ship as soon as someone gets the opportunity to review it and approve it |
💯 Just wanted to mention these things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great, so much cleaner than the v10 equivalent. if you believe v11 beta is good enough to ship, i'm happy to merge :)
Let's do it |
question, with this, is there a best practice to enable ssr for prefetching data? I noticed that here we use createTRPCReact instead of createTRPCNext so we cant just enable ssr. Thanks for all the hard work, yall are the best! |
@alexander-densley I could be wrong, but pretty sure |
No the ”bridge” between RQ and RSC data hasnt been closed in this update. We’re still experimenting with how this could look (for example, see trpc/trpc#5451) |
Closes #
✅ Checklist
Changelog
[Short description of what has changed]
Screenshots
[Screenshots]
💯