Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use trpc 11 #1741

Merged
merged 18 commits into from
Mar 14, 2024
Merged

feat: use trpc 11 #1741

merged 18 commits into from
Mar 14, 2024

Conversation

juliusmarminge
Copy link
Member

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

[Short description of what has changed]


Screenshots

[Screenshots]

💯

Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
t3-upgrade ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 8:44pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
create-t3-app ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2024 8:44pm

Copy link

changeset-bot bot commented Jan 23, 2024

🦋 Changeset detected

Latest commit: 09119f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 23, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 98
🟢 Accessibility 91
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://create-t3-app-git-trpc11-t3-oss.vercel.app/

Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr looks good. how do you feel about merging while trpc v11 is still in beta? from what i understand APIs/interfaces aren't guaranteed to be stable (in terms of semver) yet?

@juliusmarminge
Copy link
Member Author

pr looks good. how do you feel about merging while trpc v11 is still in beta? from what i understand APIs/interfaces aren't guaranteed to be stable (in terms of semver) yet?

always a fine line to draw... I'm okay merging it cause I can easily make any necessary updates to the template if necessary. Although I guess people initting might not feel the same...

I'm exclusively using v11 right now, and Alex and Nick are using it at work, but I understand we're special cases 🫣

@@ -6,7 +6,7 @@ import { api } from "~/trpc/server";

export default async function Home() {
noStore();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does noStore() still required after the change of src/trpc/server.ts? Removing it no longer cause dynamic-server-error when next build

@crivera
Copy link

crivera commented Feb 12, 2024

Is there a way to use this without being merged? npm create t3-app@trpc11?

Thank you

@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Feb 12, 2024
Copy link
Contributor

github-actions bot commented Feb 12, 2024

A new create-t3-app prerelease is available for testing. You can install this latest build in your project with:

pnpm create [email protected]

@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Feb 12, 2024
@markomitranic
Copy link

@juliusmarminge is there a goal for when this will get merged?

Asking simply because not sure if we will be waiting for trpc to exit beta before its merged - in which case I won't wait for it and will adopt this PR manually in my project :)

@nate-vukovich
Copy link

Is there a plan or maybe an ETA for this? I've basically copied the changes into my codebase :D

Maybe a waaay of crazy question but maybe a dedicated branch for all the crazy beta unstable stuff? Since Auth.js is also in experimental mode ( and I already went on latest with it ).

Cheers and regards from Austria.

@LZL0
Copy link

LZL0 commented Mar 13, 2024

Is there a plan or maybe an ETA for this? I've basically copied the changes into my codebase :D

Maybe a waaay of crazy question but maybe a dedicated branch for all the crazy beta unstable stuff? Since Auth.js is also in experimental mode ( and I already went on latest with it ).

Cheers and regards from Austria.

Good question. Both TRPC 11 and Next Auth 5 (Auth.js) are coming out over the next several weeks. Meanwhile, Prisma has released a new serverless edge driver for Neon.tech and Planetscale.

@stunaz
Copy link

stunaz commented Mar 13, 2024

Not sure why prisma is mentioned here.I am using the latest of everything… auth 5, trpc 11, react-query 5… all is good , been using this PR

@juliusmarminge
Copy link
Member Author

This'll ship as soon as someone gets the opportunity to review it and approve it

@LZL0
Copy link

LZL0 commented Mar 14, 2024

Not sure why prisma is mentioned here.I am using the latest of everything… auth 5, trpc 11, react-query 5… all is good , been using this PR

💯 Just wanted to mention these things.

Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, so much cleaner than the v10 equivalent. if you believe v11 beta is good enough to ship, i'm happy to merge :)

@juliusmarminge juliusmarminge added this pull request to the merge queue Mar 14, 2024
@juliusmarminge
Copy link
Member Author

Let's do it

Merged via the queue into main with commit 5de586d Mar 14, 2024
267 checks passed
@juliusmarminge juliusmarminge deleted the trpc11 branch March 14, 2024 19:32
@alexander-densley
Copy link

question, with this, is there a best practice to enable ssr for prefetching data? I noticed that here we use createTRPCReact instead of createTRPCNext so we cant just enable ssr. Thanks for all the hard work, yall are the best!

@maiconcarraro
Copy link

question, with this, is there a best practice to enable ssr for prefetching data? I noticed that here we use createTRPCReact instead of createTRPCNext so we cant just enable ssr. Thanks for all the hard work, yall are the best!

@alexander-densley I could be wrong, but pretty sure createTRPCReact is to enable tanstack/react-query for client side, for the server it's using the createCallerFactory

@juliusmarminge
Copy link
Member Author

No the ”bridge” between RQ and RSC data hasnt been closed in this update. We’re still experimenting with how this could look (for example, see trpc/trpc#5451)

devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.