-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lazy load cookies #1654
fix: lazy load cookies #1654
Conversation
🦋 Changeset detectedLatest commit: f2ae2cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://core-9emj8cku7-ambrosia-e4d5fc28.vercel.app/ |
I've been playing around and I know this is WIP, but just in case wanted to mention that the error is still raised on
|
What node version? |
21.1.0 |
Experiencing the same issue. Implemented the proposed changes on a brand new project and the deployments are still failing. Here is the error on Vercel:
Repo and the deployment link Runs fine locally in dev mode and production. Edit: deployment works when Vercel Authentication is disabled in deployment settings (thanks to @sscotth on Discord for the tip) |
I tried making these tweaks both on my existing t3-app and on a new project and these edits still do not allow static rendering via |
I fix it by setting the Also, components that need to dynamic, but cookie() is being used within tRPC (warning), I am using:
Basically Next is trying to generate the static page, but if it is using something that needs to be dynamic, it will not let it be dynamic. |
no window during ssr, which is when we need the cookies if we don't wanna throw 401s |
Concluded this wasn't actually the fix I thought it was |
Closes #1599
Closes #1639
✅ Checklist
Changelog
Lazy load cookies in order to not force layout to be forced dynamic
Screenshots
💯