-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add more db options #1622
Conversation
🦋 Changeset detectedLatest commit: cfa68bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@ronanru is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
cli/template/extras/src/server/db/index-drizzle/with-postgres.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea here but there are stuff we need to make sure before merging this.
What's the dev story? Should we include a db container? Recommend something like DBngin? How should the developer get the database running as quickly as possible in dev, without drifting away from the production environment?
And as I previously commented, we are not adding neon.
I think adding a script that creates a db container is a great idea. I will add it in a future commit. Edit: Added it |
So sorry for the delay, but today I tested a lot of this out and I have to say awesome work! However, using Bun, Drizzle and SQLite doesn't quite work, also Bun has it's own sqlite implementation which supposedly is faster etc. Should we use that? https://orm.drizzle.team/docs/get-started-sqlite#bun-sqlite EDIT: hmm doesn't look like db push works for that :/ |
the DATABASE_URL for prisma+planetscale also doesn't work, you need to change the ssl query param: - DATABASE_URL='mysql://user:[email protected]/db?ssl={"rejectUnauthorized":true}'
+ DATABASE_URL='mysql://user:[email protected]/db?sslaccept=strict' Fixed in 60914c7 |
Current published version is |
I'm fine just not suppporting that combo to begin with, and let people open issue if they run into it 😅 ... Gonna merge this |
Co-authored-by: juliusmarminge <[email protected]>
Closes #1617
Closes #1646
✅ Checklist
Changelog
Add a database selector, if user chose an ORM.
Screenshots
💯