Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add drizzle #1461

Merged
merged 81 commits into from
Sep 11, 2023
Merged

feat: add drizzle #1461

merged 81 commits into from
Sep 11, 2023

Conversation

juliusmarminge
Copy link
Member

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

[Short description of what has changed]

Screenshots

[Screenshots]

💯

@vercel
Copy link

vercel bot commented Jun 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
t3-upgrade ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2023 6:54am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
create-t3-app ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2023 6:54am

@changeset-bot
Copy link

changeset-bot bot commented Jun 4, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 4e8fe9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 📌 area: ci Relates to CI / GitHub Actions 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Jun 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 81
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://create-t3-app-git-drizzle-t3-oss.vercel.app/

@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Jun 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023 •
edited
Loading

Hey t3-oss/translators!

This PR contains changes to your language. Please review the changes ❤️.

@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Jun 4, 2023
@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Jun 4, 2023
@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Jun 4, 2023
@juliusmarminge juliusmarminge marked this pull request as ready for review June 4, 2023 16:41
@juliusmarminge juliusmarminge mentioned this pull request Jun 4, 2023
Open
@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Jun 4, 2023
@juliusmarminge juliusmarminge added 🚀 autorelease add this label to a pr to trigger a beta release and removed 🚀 autorelease add this label to a pr to trigger a beta release labels Jun 4, 2023
@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Sep 5, 2023
@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Sep 5, 2023
c-ehrlich
c-ehrlich approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@c-ehrlich c-ehrlich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookin good

(but lets wait on a review from the drizzle team before merging)

AndriiSherman
AndriiSherman reviewed Sep 10, 2023
View reviewed changes
Copy link

@AndriiSherman AndriiSherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to share some ideas for useful changes to Drizzle in create-t3-app

www/src/pages/pl/faq.md Outdated Show resolved Hide resolved
www/src/pages/en/faq.mdx Outdated Show resolved Hide resolved
cli/template/extras/src/server/db/drizzle-schema-base.ts Outdated Show resolved Hide resolved
cli/template/extras/src/server/db/drizzle-schema-auth.ts Outdated Show resolved Hide resolved
@juliusmarminge juliusmarminge added this pull request to the merge queue Sep 11, 2023
@juliusmarminge
Copy link
Member Author

Ship 🚢

Merged via the queue into next with commit 8034db0 Sep 11, 2023
42 checks passed
@juliusmarminge juliusmarminge deleted the drizzle branch September 11, 2023 18:44
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Merged
@checkerschaf
Copy link

Thanks a lot to all of you who have contributed to this 🙏

devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@juliusmarminge @c-ehrlich
@not-ani @wiktrek
feat: add drizzle (t3-oss#1461)
ec71213 
Co-authored-by: c-ehrlich <[email protected]>
Co-authored-by: Midas <[email protected]>
Co-authored-by: wiktrek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GermanJablo GermanJablo GermanJablo left review comments

@AndriiSherman AndriiSherman AndriiSherman left review comments

@andreifilip123 andreifilip123 andreifilip123 left review comments

@michalbundyra michalbundyra michalbundyra left review comments

@t3dotgg t3dotgg t3dotgg left review comments

@c-ehrlich c-ehrlich c-ehrlich approved these changes

@nexxeln nexxeln Awaiting requested review from nexxeln

Assignees
No one assigned
Labels
📌 area: ci Relates to CI / GitHub Actions 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App 📚 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.