-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ReactQueryDevtools to the project by default #329
Comments
I personally have never used the dev tools, curious to see how many people want this, because if someone never uses it and its installed by default, its just bloat. |
I've also never used the dev tools |
I do use the react-query dev-tools, though I personally do not think it should be included. My reasoning for not including it is mostly along the lines that the setup for the dev-tools is a simple NPM install and the import and rendering of the component. Kind of like the prettier discussion a few months back. |
I was thinking about this, and I believe putting it as a comment is enough. So it'll not be added, but the user has a hint where to put the devtool. I'm suggesting this because it's the first time I'm using the t3 stack, and it took some time for me to figure out where the dev tool should go because I was unaware that <SessionProvider session={session}>
{/*
* Uncomment this to show the devtools
* <ReactQueryDevtools initialIsOpen={false} />
*/}
<Component {...pageProps} />
</SessionProvider> |
i tend to use them sooner or later in most of my projects, but as for adding them to ct3a (commented out), i don't feel strongly for or against. |
I think we should either do this or the trpc logger #296 (comment) |
I think this almost lands in the |
Is your feature request related to a problem? Please describe.
ReactQueryDevtools is so helpful that I believe this should be a standard in the t3 stack, it's much more common to need it than doesn't, so I suggest adding it to the project.
Describe the solution you'd like to see
I believe we are safe to always add it if a user chooses to use tRPC in the CLI.
Desribe alternate solutions
In my perspective, we don't need to add it as an option in "
Which packages would you like to enable?
" stepAdditional information
I'll be glad to add this feature to the project :)
The text was updated successfully, but these errors were encountered: