Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ReactQueryDevtools to the project by default #329

Closed
itelo opened this issue Aug 18, 2022 · 7 comments
Closed

feat: add ReactQueryDevtools to the project by default #329

itelo opened this issue Aug 18, 2022 · 7 comments
Labels
📌 area: t3-app Relates to the generated T3 App 🌟 enhancement New feature or request 💬 discussion Issue needs further discussion before decision

Comments

@itelo
Copy link

itelo commented Aug 18, 2022

Is your feature request related to a problem? Please describe.

ReactQueryDevtools is so helpful that I believe this should be a standard in the t3 stack, it's much more common to need it than doesn't, so I suggest adding it to the project.

Describe the solution you'd like to see

I believe we are safe to always add it if a user chooses to use tRPC in the CLI.

Desribe alternate solutions

In my perspective, we don't need to add it as an option in "Which packages would you like to enable?" step

Additional information

I'll be glad to add this feature to the project :)

@itelo itelo added the 🌟 enhancement New feature or request label Aug 18, 2022
@nexxeln
Copy link
Member

nexxeln commented Aug 18, 2022

I personally have never used the dev tools, curious to see how many people want this, because if someone never uses it and its installed by default, its just bloat.

@nexxeln nexxeln added 💬 discussion Issue needs further discussion before decision 📌 area: t3-app Relates to the generated T3 App labels Aug 18, 2022
@flowergardn
Copy link
Contributor

I personally have never used the dev tools, curious to see how many people want this, because if someone never uses it and its installed by default, its just bloat.

I've also never used the dev tools

@SeanCassiere
Copy link

SeanCassiere commented Aug 18, 2022

I do use the react-query dev-tools, though I personally do not think it should be included.

My reasoning for not including it is mostly along the lines that the setup for the dev-tools is a simple NPM install and the import and rendering of the component. Kind of like the prettier discussion a few months back.

@itelo
Copy link
Author

itelo commented Aug 18, 2022

I was thinking about this, and I believe putting it as a comment is enough. So it'll not be added, but the user has a hint where to put the devtool.

I'm suggesting this because it's the first time I'm using the t3 stack, and it took some time for me to figure out where the dev tool should go because I was unaware that withTRPC was actually an HoC with QueryProvider inside it.

<SessionProvider session={session}>
  {/*
    * Uncomment this to show the devtools
    * <ReactQueryDevtools initialIsOpen={false} /> 
    */}
    <Component {...pageProps} />
</SessionProvider>

@c-ehrlich
Copy link
Member

c-ehrlich commented Aug 18, 2022

i tend to use them sooner or later in most of my projects, but as for adding them to ct3a (commented out), i don't feel strongly for or against.

@t3dotgg
Copy link
Member

t3dotgg commented Aug 20, 2022

I think we should either do this or the trpc logger #296 (comment)

@juliusmarminge
Copy link
Member

I think this almost lands in the npm install section. A single line of boilerplate isn't enough imo, rather have we setup the tRPC logger instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: t3-app Relates to the generated T3 App 🌟 enhancement New feature or request 💬 discussion Issue needs further discussion before decision
Projects
None yet
Development

No branches or pull requests

7 participants