Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add react-query-devtools #1206

Closed
erfanansari opened this issue Feb 14, 2023 · 3 comments
Closed

feat: add react-query-devtools #1206

erfanansari opened this issue Feb 14, 2023 · 3 comments
Labels
📌 area: t3-app Relates to the generated T3 App 🌟 enhancement New feature or request

Comments

@erfanansari
Copy link

Is your feature request related to a problem? Please describe.

I was thinking if it's a good idea to add react query devtools by default in the template, as it can help to debug and inspect fetch requests.

Describe the solution you'd like to see

Installing @tanstack/react-query-devtools package and putting ReactQueryDevtools component in the _app.tsx file.

Describe alternate solutions

There is no alternate solution.

Additional information

No response

@erfanansari erfanansari added the 🌟 enhancement New feature or request label Feb 14, 2023
@c-ehrlich
Copy link
Member

c-ehrlich commented Feb 14, 2023

We had this discussion a few months ago and decided to add the tRPC logger by default, but leave the RQ devtools for the user to add as this is a one line change. #329

Personally I still don't think we need to have them on by default, but will leave this open.

@juliusmarminge
Copy link
Member

It is a nice thing to have and even though it is a one-line addition might be worth it just for educational purposes?

@juliusmarminge juliusmarminge added the 📌 area: t3-app Relates to the generated T3 App label Feb 16, 2023
@erfanansari
Copy link
Author

I can create a PR for it if you are okay with it.

@juliusmarminge juliusmarminge closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: t3-app Relates to the generated T3 App 🌟 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants