Allow time dimensions for date columns #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgutgon
force-pushed
the
feature/allow-time-dimensions-for-dates
branch
from
7a1520a to
b2e6a51
Compare
andresgutgon
force-pushed
the
feature/allow-time-dimensions-for-dates
branch
from
b2e6a51 to
16f93b3
Compare
t27duck
reviewed
Oct 15, 2018
| @@ -32,6 +32,29 @@ def test_report_runs_with_an_aggregate_other_than_count | |||
| assert data.all? { |r| r.key?('a_metric') } | |||
| end | |||
|
|
|||
| def test_report_runs_with_a_year_grouping | |||
| if ENV['DB'] == 'pg' | |||
There was a problem hiding this comment.
Would this not work with MySQL as well?
There was a problem hiding this comment.
I did a helper function in the other pr, I can change here after merge the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info on this issue