Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major changes here are
actix-web
andpostgres
, with the latter being especially painful.A couple of noteworthy things here:
postgres
because you're supposed to cache them externally, but they're probably bound to a connection but we use a connection per request, so I doubt they worked even beforepostgres
now uses atokio
runtime for each blocking, leading to panics (you can't start a run-time from another); I added someactix_web::web::block
calls to dispatch those on a thread pool, but that's a good idea anyway since it leaves the reactor threads free for network transfer. Ideally, we'd use the async Postgres client instead, but the datasets are not async yet.r2d2_postgres
is annoying