-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deletion callback; replace edited mention; start mention without " " before #136
Open
tertmax
wants to merge
13
commits into
szweier:master
Choose a base branch
from
tertmax:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tertmax
commented
Oct 5, 2020
- Added a callback that helps with handling of the deleted mention.
- Added a flag 'replaceEditedMention'. With it set to true, the edited mention will be fully replaced with a new one. The default value is false in order to preserve original behaviour.
- Added a flag 'considerTextBefore'. With it set to false, mentioning can be triggered without " " before the trigger symbols. The default value is true in order to preserve original behaviour.
[add] additional properties
Feature replace edited mention
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
===========================================
- Coverage 100.00% 99.65% -0.35%
===========================================
Files 21 21
Lines 1003 876 -127
===========================================
- Hits 1003 873 -130
- Misses 0 3 +3
Continue to review full report at Codecov.
|
…rder to handle emojis
[fix] converting NSRange and offset from textView to Swift.Index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.