Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletion callback; replace edited mention; start mention without " " before #136

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

tertmax
Copy link

@tertmax tertmax commented Oct 5, 2020

  • Added a callback that helps with handling of the deleted mention.
  • Added a flag 'replaceEditedMention'. With it set to true, the edited mention will be fully replaced with a new one. The default value is false in order to preserve original behaviour.
  • Added a flag 'considerTextBefore'. With it set to false, mentioning can be triggered without " " before the trigger symbols. The default value is true in order to preserve original behaviour.

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #136 (59231a4) into master (967d7d9) will decrease coverage by 0.34%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #136      +/-   ##
===========================================
- Coverage   100.00%   99.65%   -0.35%     
===========================================
  Files           21       21              
  Lines         1003      876     -127     
===========================================
- Hits          1003      873     -130     
- Misses           0        3       +3     
Impacted Files Coverage Δ
Classes/Internal/String.swift 95.00% <80.00%> (-5.00%) ⬇️
Classes/MentionListener.swift 98.83% <89.47%> (-1.17%) ⬇️
Classes/Internal/Operators.swift 100.00% <0.00%> (ø)
Classes/Internal/MentionsArray.swift 100.00% <0.00%> (ø)
Classes/Internal/NSAttributedString.swift 100.00% <0.00%> (ø)
SZMentionsSwiftTests/DelegatesTests.swift 100.00% <0.00%> (ø)
SZMentionsSwiftTests/CreateMentionTests.swift 100.00% <0.00%> (ø)
SZMentionsSwiftTests/AddingMentionsTests.swift 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 967d7d9...59231a4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant