Dovecot Lua auth: Various fixes #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y3n4
force-pushed
the
lua-dovecot-fix-quota
branch
from
82e9288
to
4ad0a22
Compare
y3n4
changed the title
y3n4
requested review from
0x46616c6b,
doobry-systemli and
t2d
as code owners
doobry-systemli
approved these changes
Dec 2, 2024
0x46616c6b
requested changes
Dec 2, 2024
src/Controller/DovecotController.php
Outdated
| @@ -116,12 +121,16 @@ public function authenticate( | |||
| $mailCryptReported = 0; | |||
| } | |||
|
|
|||
| $customQuota = $user->getQuota(); | |||
| $customQuotaString = $customQuota !== null ? sprintf('*:storage=%dM', $customQuota) : ""; | |||
There was a problem hiding this comment.
This code duplication should be extracted to an internal function
There was a problem hiding this comment.
I noticed that the code duplication wasn't necessary in the first place and removed it. Returning the quota only for the user lookup is sufficient
y3n4
force-pushed
the
lua-dovecot-fix-quota
branch
from
cd6d1ad
to
ac6cc9d
Compare
y3n4
force-pushed
the
lua-dovecot-fix-quota
branch
from
bd6e2ea
to
fb3dbd2
Compare
y3n4
force-pushed
the
lua-dovecot-fix-quota
branch
from
fb3dbd2
to
162d50c
Compare
|
0x46616c6b
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.