-
Notifications
You must be signed in to change notification settings - Fork 7
Change the import syntax to a more friend and customizable way #11
base: master
Are you sure you want to change the base?
Conversation
Change import syntax. Change to ES6 Module.
According to jspm package specification.
add some documentaion.
@@ -1,8 +1,24 @@ | |||
{ | |||
"main": "font", | |||
"author": [ | |||
"LukeXuan" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This I assume is an oversight, and should either be removed or changed to something more generic, like systemjs-font contributors
. If we include everyone here, which is another good alternative, I think it will become stall fairly quickly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well that's my fault, going to correct it in the next commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modify to all contributors listed in github and generic authors appended. It was my fault to add only my name on it when I want to complete the package.json
. Please forgive my offense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, I've done this myself.
Changing the format will break existing code, and should be avoided if possible. If however this doesn't do that I'm ok with this. But please add, not remove, tests for both formats to ensure this. |
Changing the format was my original propose, since It's hard to understand the original format from the |
Maybe I'll contribute more time on the original repository and this pr I will close. |
That not so good, let's pull in @guybedford to hear what he has to say. (Maybe I'm just being paranoid and we should bump a major version) |
Thanks for the PR. Plugin contributors are very much in need. How about |
@guybedford I originally intended to use that one. However I find that the address I receive by |
@LukeXuan I've updated the URL polyfill implementation in SystemJS to properly support |
@LukeXuan Thanks, it works. So, does this PR become official system-font? |
@LukeXuan jspm bundle-sfx error...
|
I've changed the syntax of import to
And should support all Typekit modules.
Also I added the
registry
key to thepackage.json
, absence of which causes the original package not to work here.