fix(dal): Ensure we re-run prototype functions when they are enqueued, even when they have no downstream dependencies #5290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, even when they have no downstream dependencies
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an edge case, where if you're changing the bindings for Props/Output Sockets and the variant in question has components created that are auto-upgrading, if the existing attribute values for the binding being changed doesn't have any downstream dependencies, we were never re-executing that prototype function as we only add values to the
DependentValuesGraphwhen we find downstream impacts. This adds the independent value to the graph at the onset, ensuring it's function runs.This was not tested thoroughly yet, so draft mode until then and more discussion can be had.