Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

journal: replace truncating with punching holes (v252) #434

Open
wants to merge 5 commits into
base: v252-stable
Choose a base branch
from
Open

journal: replace truncating with punching holes (v252) #434

wants to merge 5 commits into from

Commits on Aug 12, 2024

  1. test-journal-flush: minor modernizations 

    let's automatically destroy test dirs, instead of manually.

(cherry picked from commit 951174e)
    @poettering @orgads
    poettering authored and orgads committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    060b3b0 View commit details
    Browse the repository at this point in the history

  2. test: modernize test-journal-flush 

    (cherry picked from commit ff95b60)
    @yuwata @orgads
    yuwata authored and orgads committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    53b99e3 View commit details
    Browse the repository at this point in the history

  3. journal-file-util: do not fail when journal_file_set_offline() called… 

    … more than once

Previously, if journal_file_set_offline() is called twice with 'wait = false',
the second call triggered segfaults, as the offline_state is OFFLINE_DONE,
and journal_file_set_offline_thread_join() tries to call pthread_join()
with NULL.

(cherry picked from commit 46e98df)
    @yuwata @orgads
    yuwata authored and orgads committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    c5e8029 View commit details
    Browse the repository at this point in the history

  4. journal-file-util: Prefer punching holes instead of truncating 

    It seems truncating might cause SIGBUS (#24320). Let's play it safe
and always prefer punching holes over truncating.

(cherry picked from commit f20c07d)
    @DaanDeMeyer @orgads
    DaanDeMeyer authored and orgads committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    db14a20 View commit details
    Browse the repository at this point in the history

  5. test: add reproducer for SIGBUS issue caused by journal truncation 

    The added code fails without the previous commit.

For issue #24320.

(cherry picked from commit 3b0ae13)
    @yuwata @orgads
    yuwata authored and orgads committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    32f9e12 View commit details
    Browse the repository at this point in the history