v252 batch #333
Merged
v252 batch #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't do anything about them anyway, and most importantly this seems to alleviate systemd/systemd-centos-ci#660, which should make the CIs a bit less angry (at least until the issue is addressed properly). (cherry picked from commit 3a89904) (cherry picked from commit af7d007) (cherry picked from commit 4dfce10)
On slower/overloaded systems it may take a bit for the swtpm socket to show up: I: Started swtpm as PID 189419 with state dir /tmp/tmp.pWqUutuGUj I: Configured emulated TPM2 device tpm-spapr + tee /var/tmp/systemd-test-TEST-70-TPM2_1/console.log + timeout --foreground 1200 /bin/qemu-system-ppc64le -smp 4 ... qemu-system-ppc64le: -chardev socket,id=chrtpm,path=/tmp/tmp.pWqUutuGUj/sock: Failed to connect to '/tmp/tmp.pWqUutuGUj/sock': No such file or directory E: qemu failed with exit code 1 Spotted regularly in the ppc64le cron job and in some Ubuntu CI/CentOS CI pr runs [0]. [0] systemd/systemd#29183 (comment) (cherry picked from commit 18c3ffb) (cherry picked from commit 2171f68) (cherry picked from commit bf449d7)
We might need a lot of fds on large systems, hence raise RLIMIT_NOFILE to what the service manager allows us, which is quite a lot these days. udev already sets FORK_RLIMIT_NOFILE_SAFE when forking of chilren, thus ensuring that forked off processes get their RLIMIT_NOFILE soft limit reset to 1K for compat with crappy old select(). Replaces: #29298 Fixes: #28583 (cherry picked from commit 1617424) (cherry picked from commit c98a24b) (cherry picked from commit b60cf1f)
...
uint8_t c;
struct trie_node *child;
for (p = 0; (c = trie->strings->buf[node->prefix_off + p]); p++) {
_cleanup_free_ struct trie_node *new_child = NULL;
_cleanup_free_ char *s = NULL;
ssize_t off;
if (c == search[i + p])
continue;
...
When '®' is present in search, c is 194, search[i + p] is -62, c is not equal
to search[i + p], but c should be equal to search[i + p].
(cherry picked from commit b53a809)
(cherry picked from commit 3cc2aa3)
(cherry picked from commit a678987)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.