Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify indexing for function vwifi_interface_add #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vax-r
Copy link
Collaborator

@vax-r vax-r commented Feb 1, 2024

Summary

Since we implement a counter for wiphy in our project, which is vwifi_wiphy_counter. The relationship between virtual interfaces and wiphy is always one-to-one, so the indexing for virtual interfaces can be the same as wiphy.

Originally, the index for virtual interface is passed as a function parameters into the function vwifi_interface_add(). Now we modify the function, instead of using parameters as index for virtual interface, we use the value of vwifi_wiphy_counter to keep a better consistency.

Since we implement a counter for wiphy in our project, which is
vwifi_wiphy_counter. The relationship between virtual interfaces and
wiphy is always one-to-one, so the indexing for virtual interfaces can
be the same as wiphy.

Originally, the index for virtual interface is passed as a function
parameters into the function vwifi_interface_add(). Now we modify the
function, instead of using parameters as index for virtual interface,
we use the value of vwifi_wiphy_counter to keep a better consistency.
@vax-r vax-r requested a review from jserv February 1, 2024 09:00
@jserv
Copy link
Contributor

jserv commented Feb 1, 2024

Can you check if the proposed change works with namespace?

@vax-r
Copy link
Collaborator Author

vax-r commented Feb 1, 2024

Can you check if the proposed change works with namespace?

Do you mean can we use the same approach on the index for namespace such as ns0 and ns1?

@jserv
Copy link
Contributor

jserv commented Feb 1, 2024

Do you mean can we use the same approach on the index for namespace such as ns0 and ns1?

Indeed, it is important to recognize that the primary aim of implementing vwifi is to facilitate its deployment within containerized or virtualized environments.

@vax-r
Copy link
Collaborator Author

vax-r commented Feb 1, 2024

Do you mean can we use the same approach on the index for namespace such as ns0 and ns1?

Indeed, it is important to recognize that the primary aim of implementing vwifi is to facilitate its deployment within containerized or virtualized environments.

No problem, let me try to make it possible.

@jserv
Copy link
Contributor

jserv commented May 21, 2024

I would like to ask @jychen0611 to rework this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants