Merge pull request #148 from visitorckw/fix-strncmp

Fix potential out-of-bounds access in strncmp()
sysprog21 · Aug 10, 2024 · 4b8c4e6 · 4b8c4e6
2 parents c56c590 + 529d827
commit 4b8c4e6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/lib/c.c b/lib/c.c
@@ -71,6 +71,8 @@ int strncmp(char *s1, char *s2, int len)
             return -1;
         if (s1[i] > s2[i])
             return 1;
+        if (!s1[i])
+            return 0;
         i++;
     }
     return 0;

diff --git a/tests/snapshots/fib.json b/tests/snapshots/fib.json
diff --git a/tests/snapshots/hello.json b/tests/snapshots/hello.json