Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new lxml_html_clean package when available. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mauritsvanrees
Copy link
Collaborator

You need this when you are using lxml 5.2 or later. We don't want to make this a hard dependency.
When you use Plone 6.0.11 or later, you must use this new htmllaundry version. Fine for older Plone versions as well.

Note that in lxml 5.2 (or maybe all 5.x versions), the keyword arguments passed to a Cleaner must not be a string. So also our own link_target keyword argument must be a list. Changed the code accordingly.

You need this when you are using ``lxml`` 5.2 or later.
We don't want to make this a hard dependency.
When you use Plone 6.0.11 or later, you must use this new ``htmllaundry`` version.
Fine for older Plone versions as well.
@ale-rt
Copy link
Member

ale-rt commented May 20, 2024

I think this needs #3 to make at least the test pass.
I am not really sure we want anyway to continue maintaining this package.
I am not sure if the Python compatibility we claim makes sense.
Anyway I will approve the PR.

@mauritsvanrees
Copy link
Collaborator Author

The point would be to only do the changes in this one package, instead of in ploneintranet, euphorie, osha.oira, and any other packages where we use htmllaundry.

@ale-rt
Copy link
Member

ale-rt commented May 21, 2024

I would say let's get rid of this extra package.
We are working on a fork, it is not widely adopted and I think we could easily get rid of it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants