Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: int overflow for short channel IDs #185

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix: int overflow for short channel IDs #185

merged 1 commit into from
Oct 18, 2023

Conversation

Jasonvdb
Copy link
Collaborator

short_channel_id, inbound_scid_alias and inbound_payment_scid are all UInt64 types which overflow in JS numbers so converted number types to strings

@Jasonvdb Jasonvdb merged commit 9b38e9a into master Oct 18, 2023
4 of 6 checks passed
@Jasonvdb Jasonvdb deleted the scid-type-fix branch October 18, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreyphillips coreyphillips coreyphillips approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jasonvdb @coreyphillips