Add two attachment-focused metrics #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikix
commented
Nov 26, 2024
mikix
commented
- c_attachment_count: looks at attachment metadata
- c_content_type_use: looks at content types available among resources
- c_attachment_count: looks at attachment metadata - c_content_type_use: looks at content types available among resources
|
Heyo @gotdan I know you're feeling under the weather right now, no urgency on this. But here are the two metrics I had mentioned I was working on. You can also review the code for them here: smart-on-fhir/cumulus-library-data-metrics#64 |
gotdan
reviewed
Nov 27, 2024
metrics.md
Outdated
| @@ -572,6 +572,57 @@ Choice elements: | |||
| Notes: | |||
| - These are the choice fields in US Core, but could use the FHIR definitions to create a full list, or could do a more general query based on JSON key prefix (not supported by all databases and potentially slow even where supported) | |||
|
|
|||
| ### c_attachment_count | |||
| **[structure]** Survey of attachment data and formats | |||
There was a problem hiding this comment.
We don't use the term "survey" anywhere else, though I'm not necessarily averse to it. For consistency, maybe "Count of attachments by format" instead?
There was a problem hiding this comment.
"By format" might be overselling it, especially since format is a field that DiagnosticReport doesn't have. Maybe "Count of attachment metadata"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.