chore: optimize header waiting process #401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashuralyk
force-pushed
the
chore/optimize-axon
branch
from
9c9c4ad to
d0bbb6a
Compare
Flouse
reviewed
Dec 23, 2023
| @@ -238,6 +238,7 @@ impl FullNode { | |||
| packet_filter: Default::default(), | |||
| websocket_addr, | |||
| rpc_addr, | |||
| cell_emitter_addr: Url::from_str("http://127.0.0.1").unwrap(), // set it as normal in test | |||
There was a problem hiding this comment.
What about the port of cell_emitter_addr?
There was a problem hiding this comment.
this field in test-framework isn't necessary, so it can be everything including without port
blckngm
reviewed
Dec 25, 2023
| @@ -1388,8 +1388,32 @@ impl AxonChain { | |||
| Ok(e) => return Ok(e), | |||
| Err(e) => { | |||
| if e.to_string().contains("reverted: getHeader") { | |||
| std::thread::sleep(Duration::from_secs(5)); | |||
| tracing::info!("getHeader failed, waiting for header sync"); | |||
| #[cfg(not(test))] | |||
There was a problem hiding this comment.
This may not work as you would expect: https://github.com/synapseweb3/forcerelay/actions/runs/7305634478/job/19909434313?pr=401#step:19:671
(Because only the ibc-test crate would have cfg(test), not the relayer crate.)
|
I'll open a new PR including only the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.