Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add contract deployment script and configs #345

Merged
merged 7 commits into from
Oct 26, 2023

Conversation

ashuralyk
Copy link
Contributor

@ashuralyk ashuralyk commented Oct 10, 2023

Closes: #285

Description

change logs:

  1. make deployment process automatically through ckb-cli, for the utility of manual deployment
  2. move the creation of connections-cell from the ibc-test to relayer core logic
  3. fix a bug which is a wrong use of query_channels in CKB endpoint

@ashuralyk ashuralyk requested review from Flouse, jjyr and blckngm October 10, 2023 07:56
@ashuralyk
Copy link
Contributor Author

I'm writing them right in the Forcerelay repo, if it's more suitable to move them into the contract repo?

@Flouse
Copy link
Collaborator

Flouse commented Oct 10, 2023

I'm writing them right in the Forcerelay repo, if it's more suitable to move them into the contract repo?

I think it's okey.
It's appropriate to organize the integration-test deployment guild in the Forcerelay repo.

@jjyr
Copy link
Collaborator

jjyr commented Oct 11, 2023

image

Please config your editor to add a blank line at the end of file.

https://stackoverflow.com/questions/5813311/whats-the-significance-of-the-no-newline-at-end-of-file-log

@ashuralyk
Copy link
Contributor Author

Please config your editor to add a blank line at the end of file.

@jjyr it's bee confirmed

@ashuralyk
Copy link
Contributor Author

@blckngm
Copy link
Contributor

blckngm commented Oct 12, 2023

@jjyr https://github.com/synapseweb3/forcerelay/actions/runs/6478088104/job/17601648711?pr=345#step:16:418 do you know anything about this error ?

This is probably because the sudt transfer packet is not relayed to axon.

@ashuralyk
Copy link
Contributor Author

@jjyr https://github.com/synapseweb3/forcerelay/actions/runs/6478088104/job/17601648711?pr=345#step:16:418 do you know anything about this error ?

This is probably because the sudt transfer packet is not relayed to axon.

can this be fixed?

@Flouse Flouse marked this pull request as draft October 13, 2023 03:50
@ashuralyk ashuralyk force-pushed the chore/contract-deployment branch from 8c38f7d to 3486f8e Compare October 24, 2023 01:21
@ashuralyk ashuralyk marked this pull request as ready for review October 26, 2023 06:14
@ashuralyk ashuralyk requested a review from Flouse October 26, 2023 06:14
@ashuralyk ashuralyk added this pull request to the merge queue Oct 26, 2023
Merged via the queue into main with commit 54d23f7 Oct 26, 2023
31 checks passed
@ashuralyk ashuralyk deleted the chore/contract-deployment branch October 30, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[document]A complete forcerelay operation document
4 participants