-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding velodrome pool to docs #3488
Conversation
WalkthroughA documentation update has been made to the SYN token liquidity venues section. A new entry for Velodrome has been added to the existing table, providing users with an additional resource for finding liquidity information about the $SYN token on the Velodrome platform. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/bridge/docs/01-About/04-SYN.md (2)
22-22
: Consider using a shorter URL formatThe current URL is quite long and could be error-prone. Consider using a more concise format or a named link for better readability.
-| Velodrome | `https://velodrome.finance/deposit?token0=0x4200000000000000000000000000000000000006&token1=0x5A5fFf6F753d7C11A56A52FE47a177a87e431655&type=-1&factory=0xF1046053aa5682b4F9a81b5481394DA16BE5FF5a&chain=10` [↗](https://velodrome.finance/deposit?token0=0x4200000000000000000000000000000000000006&token1=0x5A5fFf6F753d7C11A56A52FE47a177a87e431655&type=-1&factory=0xF1046053aa5682b4F9a81b5481394DA16BE5FF5a&chain=10) | +| Velodrome | [SYN-WETH Pool on Optimism](https://velodrome.finance/deposit?token0=0x4200000000000000000000000000000000000006&token1=0x5A5fFf6F753d7C11A56A52FE47a177a87e431655&type=-1&factory=0xF1046053aa5682b4F9a81b5481394DA16BE5FF5a&chain=10) |🧰 Tools
🪛 Markdownlint (0.37.0)
22-22: null
Tables should be surrounded by blank lines(MD058, blanks-around-tables)
22-22
: Add blank lines around the tableAccording to markdown best practices, tables should be surrounded by blank lines for better readability.
| KuCoin | `https://www.kucoin.com/price/SYN` [↗](https://www.kucoin.com/price/SYN) | + | Velodrome | `https://velodrome.finance/deposit?token0=0x4200000000000000000000000000000000000006&token1=0x5A5fFf6F753d7C11A56A52FE47a177a87e431655&type=-1&factory=0xF1046053aa5682b4F9a81b5481394DA16BE5FF5a&chain=10` [↗](https://velodrome.finance/deposit?token0=0x4200000000000000000000000000000006&token1=0x5A5fFf6F753d7C11A56A52FE47a177a87e431655&type=-1&factory=0xF1046053aa5682b4F9a81b5481394DA16BE5FF5a&chain=10) | + <br />🧰 Tools
🪛 Markdownlint (0.37.0)
22-22: null
Tables should be surrounded by blank lines(MD058, blanks-around-tables)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/bridge/docs/01-About/04-SYN.md
(1 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
docs/bridge/docs/01-About/04-SYN.md
22-22: null
Tables should be surrounded by blank lines
(MD058, blanks-around-tables)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Deploy to Vercel (docs)
- GitHub Check: SonarCloud
🔇 Additional comments (1)
docs/bridge/docs/01-About/04-SYN.md (1)
22-22
: Verify contract addresses in the Velodrome URLPlease ensure that the contract addresses in the URL are correct:
- token0: 0x4200000000000000000000000000000000000006 (WETH on Optimism)
- token1: 0x5A5fFf6F753d7C11A56A52FE47a177a87e431655 (SYN on Optimism)
- factory: 0xF1046053aa5682b4F9a81b5481394DA16BE5FF5a
🧰 Tools
🪛 Markdownlint (0.37.0)
22-22: null
Tables should be surrounded by blank lines(MD058, blanks-around-tables)
Bundle ReportChanges will increase total bundle size by 19.37MB (156.85%) ⬆️
|
Deploying sanguine-fe with Cloudflare Pages
|
Description
A clear and concise description of the features you're adding in this pull request.
Additional context
Add any other context about the problem you're solving.
Metadata
Summary by CodeRabbit
0da5372: docs preview link