FE Release 2024-01-06 #3483
FE Release 2024-01-06 #3483
Conversation
* Link out to staking in announcement message
abtestingalpha
requested review from
bigboydiamonds and
aureliusbtc
as code owners
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
abtestingalpha
temporarily deployed
to
github-pages
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: Deploy to Vercel (synapse-interface)
- GitHub Check: lint
- GitHub Check: SonarCloud
- GitHub Check: test
- GitHub Check: Deploy to Vercel (synapse-interface)
- GitHub Check: test
- GitHub Check: SonarCloud
- GitHub Check: lint
- GitHub Check: Analyze go
- GitHub Check: Cloudflare Pages
🔇 Additional comments (2)
packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx (2)
80-83: End date extension and banner content look fine.• Updating the end date from January 25, 2025, to February 25, 2025, seems to align with the new timeline.
• Switching the inline string to theStakingBannerContentcomponent is more modular and maintains code cleanliness.
24-24: Check correctness of the newly introduced STAKE_SYN_FOR_CX_URL import.Everything looks fine here, but please verify that the constant name is consistent with other URL constants, and confirm that its value correctly points to the intended staking page.
Run the following script to search for other URL constants, ensuring consistency in naming and usage:
✅ Verification successful
URL constant follows established naming conventions and patterns
The
STAKE_SYN_FOR_CX_URLconstant is correctly named following the codebase's established URL constant patterns and points to the appropriate staking page.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any URL constants and compare naming rg -A 2 $'_URL'Length of output: 54586
| const StakingBannerContent = () => { | ||
| return ( | ||
| <div> | ||
| Stake your SYN to receive CX (Cortex Protocol) tokens{' '} | ||
| <a | ||
| href={STAKE_SYN_FOR_CX_URL} | ||
| target="blank" | ||
| className="underline hover:cursor hover:text-white/65" | ||
| > | ||
| here | ||
| </a> | ||
| ! | ||
| </div> | ||
| ) | ||
| } |
There was a problem hiding this comment.
Fix the external link to prevent security risks.
The target="blank" attribute should be target="_blank" and, as a best practice, include rel="noopener noreferrer" to reduce security vulnerabilities and prevent passing window context to other sites.
Apply the following diff to fix it:
<a
- href={STAKE_SYN_FOR_CX_URL}
- target="blank"
+ href={STAKE_SYN_FOR_CX_URL}
+ target="_blank"
+ rel="noopener noreferrer"
className="underline hover:cursor hover:text-white/65"
>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const StakingBannerContent = () => { | |
| return ( | |
| <div> | |
| Stake your SYN to receive CX (Cortex Protocol) tokens{' '} | |
| <a | |
| href={STAKE_SYN_FOR_CX_URL} | |
| target="blank" | |
| className="underline hover:cursor hover:text-white/65" | |
| > | |
| here | |
| </a> | |
| ! | |
| </div> | |
| ) | |
| } | |
| const StakingBannerContent = () => { | |
| return ( | |
| <div> | |
| Stake your SYN to receive CX (Cortex Protocol) tokens{' '} | |
| <a | |
| href={STAKE_SYN_FOR_CX_URL} | |
| target="_blank" | |
| rel="noopener noreferrer" | |
| className="underline hover:cursor hover:text-white/65" | |
| > | |
| here | |
| </a> | |
| ! | |
| </div> | |
| ) | |
| } |
- @synapsecns/[email protected]
Deploying sanguine-fe with
|
| Latest commit: |
a100d0f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://73997f24.sanguine-fe.pages.dev |
| Branch Preview URL: | https://snyk-fix-dee825cc72f0ba34122.sanguine-fe.pages.dev |
Bundle ReportChanges will increase total bundle size by 385 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Summary by CodeRabbit
39056c8: synapse-interface preview link