New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contracts-rfq): add `forwardTo` to ZapData for Zap Actions that don't forward assets to the user #3451

Merged

ChiTimesChi merged 12 commits into feat/syn-intent-router from fix/FbV2-zap-data-funds-recipient

Dec 10, 2024

Merged

fix(contracts-rfq): add `forwardTo` to ZapData for Zap Actions that don't forward assets to the user #3451

deploy: redeploy SIP, TokenZap

GitHub Advanced Security / Slither succeeded Dec 9, 2024 in 6s

3 new alerts including 1 medium severity security vulnerability

New alerts in code changed by this pull request

Security Alerts:

1 medium

Other Alerts:

2 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 97 in packages/contracts-rfq/contracts/libs/ZapDataV1.sol

Code scanning / Slither

Assembly usage Warning

ZapDataV1.finalToken(bytes) uses assembly
- INLINE ASM

Check warning on line 105 in packages/contracts-rfq/contracts/libs/ZapDataV1.sol

Code scanning / Slither

Assembly usage Warning

ZapDataV1.forwardTo(bytes) uses assembly
- INLINE ASM

Check warning on line 182 in packages/contracts-rfq/contracts/zaps/TokenZapV1.sol

Code scanning / Slither

Dangerous strict equalities Medium

TokenZapV1._forwardToken(address,address) uses a dangerous strict equality:
- amount == 0