chore(contracts-rfq): reorganise mocks, fix build script #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe pull request involves reorganizing the directory structure of the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (11)
packages/contracts-rfq/.solhintignore(1 hunks)packages/contracts-rfq/package.json(1 hunks)packages/contracts-rfq/test/FastBridge.t.sol(1 hunks)packages/contracts-rfq/test/FastBridgeV2.t.sol(1 hunks)packages/contracts-rfq/test/harnesses/UniversalTokenLibHarness.sol(1 hunks)packages/contracts-rfq/test/integration/MulticallTarget.t.sol(1 hunks)packages/contracts-rfq/test/integration/TokenZapV1.t.sol(1 hunks)packages/contracts-rfq/test/libs/UniversalTokenLib.t.sol(1 hunks)packages/contracts-rfq/test/mocks/FastBridgeMock.sol(1 hunks)packages/contracts-rfq/test/zaps/TokenZapV1.GasBench.t.sol(1 hunks)packages/contracts-rfq/test/zaps/TokenZapV1.t.sol(1 hunks)
✅ Files skipped from review due to trivial changes (9)
- packages/contracts-rfq/.solhintignore
- packages/contracts-rfq/test/harnesses/UniversalTokenLibHarness.sol
- packages/contracts-rfq/test/integration/MulticallTarget.t.sol
- packages/contracts-rfq/test/integration/TokenZapV1.t.sol
- packages/contracts-rfq/test/FastBridgeV2.t.sol
- packages/contracts-rfq/test/mocks/FastBridgeMock.sol
- packages/contracts-rfq/test/zaps/TokenZapV1.GasBench.t.sol
- packages/contracts-rfq/test/FastBridge.t.sol
- packages/contracts-rfq/test/zaps/TokenZapV1.t.sol
🔇 Additional comments (2)
packages/contracts-rfq/test/libs/UniversalTokenLib.t.sol (1)
4-4: LGTM! Import paths updated to reflect new directory structure.
The reorganization of imports aligns well with the PR objectives of restructuring mock and test-related files into dedicated directories.
Let's verify the new directory structure:
Also applies to: 6-8
✅ Verification successful
Import paths correctly updated to match new directory structure
The verification confirms that:
- New dedicated directories
mocks/andharnesses/exist underpackages/contracts-rfq/test/ - All referenced files are present in their new locations:
UniversalTokenLibHarness.solintest/harnesses/MockERC20.solandMockRevertingRecipient.solintest/mocks/
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the existence of new directories and files
# Check if the new directories exist
fd -t d "mocks|harnesses" packages/contracts-rfq/test/
# Verify the moved files exist in their new locations
fd -t f "Mock(ERC20|RevertingRecipient).sol|UniversalTokenLibHarness.sol" packages/contracts-rfq/test/
Length of output: 411
packages/contracts-rfq/package.json (1)
29-29: LGTM - Build script update aligns with mock reorganization
The updated build script properly reflects the new directory structure where mocks have been moved to dedicated subdirectories, making the codebase more organized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3434 +/- ##
============================================
Coverage ? 98.61432%
============================================
Files ? 9
Lines ? 433
Branches ? 0
============================================
Hits ? 427
Misses ? 6
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Deploying sanguine-fe with
|
| Latest commit: |
72acda2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e218f9d6.sanguine-fe.pages.dev |
| Branch Preview URL: | https://chore-fbv2-move-mocks.sanguine-fe.pages.dev |
ChiTimesChi
added a commit
that referenced
this pull request
Dec 5, 2024
ChiTimesChi
added a commit
that referenced
this pull request
Dec 10, 2024
* feat: scaffold IntentRouter * feat: initial implementation * test: single step * feat: scaffold checked/unchecked `completeIntent` * feat: implement balance checks * test: add cases where TokenZap has non-zero initial amount * test: double step cases (erc20 and/or native combos) * feat: SIR, TokenZap deployment script * deploy: test deploys for SIR * test: update to #3434 changes * feat: scaffold SIP * test: coverage for SIP * feat: Synapse Intent Previewer * feat: update deploy script, deploy SIP * fix(contracts-rfq): add `forwardTo` to ZapData for Zap Actions that don't forward assets to the user (#3451) * feat: scaffold finalToken, forwardTo in ZapDataV1 * feat: add finalToken, forwardTo * feat: scaffold TokenZap.encodeZapData * test: update existing tests * test: forwardTo scenarios * feat: token zeor address checks * feat:scaffold token forwarding * test: more revert cases * feat: final token forwarding * test: forwardTo behaviour in SIP * feat: support optional `forwardTo` in SIP * deploy: redeploy SIP, TokenZap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A clear and concise description of the features you're adding in this pull request.
Additional context
Add any other context about the problem you're solving.
Metadata
Summary by CodeRabbit
New Features
Bug Fixes
Documentation