Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Reducing dependency bloat" #3421

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

trajan0x
Copy link
Contributor

@trajan0x trajan0x commented Nov 30, 2024

Reverts #3411

Summary by CodeRabbit

  • New Features

    • Added @codecov/rollup-plugin for enhanced code coverage reporting.
  • Dependency Updates

    • Moved ethers and viem to devDependencies for better management of runtime versus development packages.
    • Reclassified several packages from devDependencies to dependencies to reflect their new roles in the project.

Copy link
Contributor

coderabbitai bot commented Nov 30, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request includes modifications to the package.json files for two packages: @synapsecns/sdk-router and @synapsecns/synapse-constants. In the sdk-router package, several development dependencies were removed and added back as runtime dependencies, indicating a shift in their usage. The synapse-constants package saw the addition of a new dependency, along with the relocation of existing dependencies from dependencies to devDependencies, with one version updated.

Changes

File Change Summary
packages/sdk-router/package.json - Removed @babel/core, @babel/plugin-transform-modules-commonjs, babel-jest from devDependencies.
- Added the same three packages to dependencies.
- Added jest to dependencies.
packages/synapse-constants/package.json - Added @codecov/rollup-plugin to dependencies.
- Moved ethers to devDependencies (version 5.7.2).
- Moved viem to devDependencies (version ^2.21.6).
- Retained typescript in devDependencies (version ^5.3.3).

Possibly related issues

Possibly related PRs

  • Reducing dependency bloat #3411: This PR involves changes to the package.json file for the @synapsecns/sdk-router package, specifically reorganizing dependencies between devDependencies and dependencies, which is directly related to the changes made in the main PR regarding the same file.

Suggested labels

M-ci

Suggested reviewers

  • abtestingalpha
  • trajan0x

Poem

In the code where rabbits play,
Dependencies shift and sway.
With plugins new and tools refined,
Our project hops, no bugs to find!
A joyful leap, we celebrate,
For cleaner paths, we elevate! 🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 842e1ad and a5ab4f7.

📒 Files selected for processing (2)
  • packages/sdk-router/package.json (1 hunks)
  • packages/synapse-constants/package.json (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@trajan0x trajan0x merged commit 5feb5a0 into master Nov 30, 2024
34 checks passed
@trajan0x trajan0x deleted the revert-3411-packages/packages-cleanup branch November 30, 2024 19:36
trajan0x added a commit that referenced this pull request Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant