Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally disable cors #3325

Merged
merged 1 commit into from
Oct 22, 2024
Merged

optionally disable cors #3325

merged 1 commit into from
Oct 22, 2024

Conversation

trajan0x
Copy link
Contributor

@trajan0x trajan0x commented Oct 22, 2024

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

Summary by CodeRabbit

  • New Features

    • Enhanced CORS handling configuration for improved server flexibility.
    • Updated application description to include version information for better clarity.
  • Bug Fixes

    • Corrected formatting of the application description for improved readability.

Copy link
Contributor

coderabbitai bot commented Oct 22, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request primarily focus on enhancing the configuration of the Gin server's CORS handling in core/ginhelper/server.go and modifying the Start function in services/omnirpc/cmd/cmd.go. A new global variable CorsEnabled has been introduced to conditionally apply CORS middleware, allowing for more flexible server configuration. In cmd.go, the application description has been updated to include version information, and the command list remains intact with no changes to error handling.

Changes

File Path Change Summary
core/ginhelper/server.go Added global variable CorsEnabled to control CORS middleware application; modified middleware application based on CorsEnabled. Included TODO for future improvements.
services/omnirpc/cmd/cmd.go Updated Start function to initialize app variable with name and version; corrected app description formatting. Command list preserved, error handling unchanged.

Poem

🐇 In the garden where code does bloom,
CORS now dances, dispelling gloom.
With CorsEnabled, we flex and sway,
Middleware changes brighten the day.
Versioned whispers in cmd.go sing,
A rabbit's joy for each little thing! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@trajan0x trajan0x changed the title disable cors optionally disable cors Oct 22, 2024
@github-actions github-actions bot added go Pull requests that update Go code size/xs labels Oct 22, 2024
Copy link

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 399534a
Status: ✅  Deploy successful!
Preview URL: https://4215a0e8.sanguine-fe.pages.dev
Branch Preview URL: https://fix-cors-optional.sanguine-fe.pages.dev

View logs

@trajan0x trajan0x merged commit 0651118 into master Oct 22, 2024
28 of 29 checks passed
@trajan0x trajan0x deleted the fix/cors-optional branch October 22, 2024 18:05
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.24226%. Comparing base (a813e05) to head (399534a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
services/omnirpc/cmd/cmd.go 0.00000% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #3325         +/-   ##
===================================================
- Coverage   33.26143%   33.24226%   -0.01917%     
===================================================
  Files            543         543                 
  Lines          34767       34769          +2     
  Branches          82          82                 
===================================================
- Hits           11564       11558          -6     
- Misses         22181       22187          +6     
- Partials        1022        1024          +2     
Flag Coverage Δ
cctp-relayer 31.97848% <ø> (ø)
core 58.64881% <100.00000%> (+0.01204%) ⬆️
ethergo 47.22625% <ø> (-0.13178%) ⬇️
git-changes-action 23.48315% <ø> (ø)
omnirpc 32.65401% <0.00000%> (-0.01513%) ⬇️
opbot 0.48870% <ø> (ø)
promexporter 6.81642% <ø> (ø)
screener-api 29.95090% <ø> (ø)
scribe 18.24614% <ø> (+0.06432%) ⬆️
tools 30.55118% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code needs-go-generate-services/rfq size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant