Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades to latest vercel cli package #1556

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

abtestingalpha
Copy link
Collaborator

@abtestingalpha abtestingalpha commented Nov 10, 2023

null
c7ad3bdbe667131038ee4382cdc8bd43d47473d4: synapse-interface preview link

Summary by CodeRabbit

  • Chores
    • Updated the Vercel CLI version for improved deployment process and interactions with Vercel services.
  • Refactor
    • Simplified the InputContainer component by removing unused imports and state variables.

Copy link
Contributor

coderabbitai bot commented Nov 10, 2023

Walkthrough

The changes involve an update to the Vercel CLI version in the GitHub workflow, and a simplification of state management in the InputContainer component of the Synapse Interface package.

Changes

File Path Change Summary
.github/workflows/ui-preview.yaml Updated Vercel CLI version from 30.1.0 to 32.5.3
.../StateManagedBridge/InputContainer.tsx Removed import of stringToBigInt, destructuring of toChainId and toToken, and updated useState hook initialization

Poem

On this day of autumn's hue, 🍂

Code changes are made, shiny and new. 💻

Like leaves falling, old code takes flight, 🍁

Making way for updates, oh so bright! 🌟


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@github-actions github-actions bot added M-ci Module: CI size/xs labels Nov 10, 2023
@abtestingalpha abtestingalpha force-pushed the fe/try-latest-vercel-package branch from 0f45a13 to c735073 Compare November 10, 2023 16:47
Copy link

cloudflare-workers-and-pages bot commented Nov 10, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c735073
Status: ✅  Deploy successful!
Preview URL: https://3a8b50e3.sanguine.pages.dev
Branch Preview URL: https://fe-try-latest-vercel-package.sanguine.pages.dev

View logs

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c557df6) 51.62073% compared to head (c735073) 51.26346%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #1556         +/-   ##
===================================================
- Coverage   51.62073%   51.26346%   -0.35727%     
===================================================
  Files            372         362         -10     
  Lines          25544       24694        -850     
  Branches         283         283                 
===================================================
- Hits           13186       12659        -527     
+ Misses         11068       10807        -261     
+ Partials        1290        1228         -62     
Flag Coverage Δ
cctp-relayer ?
packages 91.00610% <ø> (ø)
promexporter ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abtestingalpha abtestingalpha marked this pull request as ready for review November 10, 2023 17:17
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9ec5f4f and c735073.
Files selected for processing (2)
  • .github/workflows/ui-preview.yaml (1 hunks)
  • packages/synapse-interface/components/StateManagedBridge/InputContainer.tsx (2 hunks)
Additional comments: 4
.github/workflows/ui-preview.yaml (1)
  • 77-83: The Vercel CLI version has been updated from 30.1.0 to 32.5.3. Ensure that the new version doesn't introduce any breaking changes that could affect the deployment process. Also, verify that the new features and improvements are compatible with the current workflow.
-        run: npm install --global [email protected]
+        run: npm install --global [email protected]
packages/synapse-interface/components/StateManagedBridge/InputContainer.tsx (3)
  • 4-10: The import of stringToBigInt has been removed. Ensure that this function is not used elsewhere in the file or that its functionality has been replaced.

  • 22-25: The destructuring of toChainId and toToken from useBridgeState() has been removed. Make sure that these variables are not used elsewhere in the file or that their functionality has been replaced.

  • 22-25: The useState hook has been updated to only initialize showValue and hasMounted. This simplifies the state management within the InputContainer component.

@abtestingalpha abtestingalpha merged commit 132e8c6 into master Nov 10, 2023
43 checks passed
@abtestingalpha abtestingalpha deleted the fe/try-latest-vercel-package branch November 10, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants