fix: zero quote prioroty check

synapsecns · Jan 23, 2025 · 4e6954c · 4e6954c
1 parent 071f674
commit 4e6954c
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/packages/sdk-router/src/rfq/engine/priority.ts b/packages/sdk-router/src/rfq/engine/priority.ts
@@ -1,3 +1,5 @@
+import { Zero } from '@ethersproject/constants'
+
 import { SupportedChainId } from '../../constants'
 import { EngineID, SwapEngineQuote } from './swapEngine'
 
@@ -41,10 +43,16 @@ export const compareQuotesWithPriority = (
 ): SwapEngineQuote => {
   const priorityA = getEnginePriority(quoteA.engineID, quoteA.chainId)
   const priorityB = getEnginePriority(quoteB.engineID, quoteB.chainId)
-  if (priorityA === priorityB) {
-    return quoteA.expectedAmountOut.gt(quoteB.expectedAmountOut)
-      ? quoteA
-      : quoteB
+  // Compare priorities only if both quotes have a non-zero amountOut.
+  if (
+    quoteA.expectedAmountOut.gt(Zero) &&
+    quoteB.expectedAmountOut.gt(Zero) &&
+    priorityA !== priorityB
+  ) {
+    return priorityA > priorityB ? quoteA : quoteB
   }
-  return priorityA > priorityB ? quoteA : quoteB
+  // Otherwise (same priority or at least one zero quote), compare amountOut.
+  return quoteA.expectedAmountOut.gte(quoteB.expectedAmountOut)
+    ? quoteA
+    : quoteB
 }