move pluralization extraction to a separate function #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AEnterprise
changed the title
|
one of the tests is still failing but i have no clue how or why and failed after merging master in, before i made any other changes, the object has |
|
this seems to work fine other then issues already noted in #39 |
pl12133
reviewed
Apr 8, 2020
| @@ -150,6 +150,8 @@ A companion ESLint plugin exists, [eslint-plugin-preact-i18n](https://www.npmjs. | |||
| - [Examples](#examples-4) | |||
| - [intl](#intl) | |||
| - [Parameters](#parameters-5) | |||
| - [defaultProvider](#defaultprovider) | |||
There was a problem hiding this comment.
I think the term "provider" has been overloaded a lot and it could become confusing, can we call this the pluralizer instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows people using the this to provide their own function that handles pluralization rules for languages currently not supported by this implementation
this is optional and the current implementation is used as default
this also brings the preactX branch back in line with the master branch as well
remake of #37
fixes #2