Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc]remove prepended doubleslash in exceptionmessage #1622

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

Butterd
Copy link
Contributor

@Butterd Butterd commented Dec 7, 2024

Removes the prepended '\' in the Exceptionmessage when encountering an invalid FCQN

#1615

#SymfonyHackday

@Butterd
Copy link
Contributor Author

Butterd commented Dec 7, 2024

Also adds a fix similar to !1620

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Butterd Butterd changed the title [doc]remove prepended doubleslash in exceptionmessage #1615 [doc]remove prepended doubleslash in exceptionmessage [#1615]https://github.com/symfony/maker-bundle/issues/1615 Dec 7, 2024
@Butterd Butterd changed the title [doc]remove prepended doubleslash in exceptionmessage [#1615]https://github.com/symfony/maker-bundle/issues/1615 [doc]remove prepended doubleslash in exceptionmessage Dec 7, 2024
@kbond
Copy link
Member

kbond commented Dec 10, 2024

Thank you @Butterd.

@kbond kbond merged commit 0624f13 into symfony:main Dec 10, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants