[make:*] add types for PHPStan #1542
Conversation
|
A commit is related to the issue: #1540 |
There was a problem hiding this comment.
Hey @seb-jean - awesome! A couple minor comments below and one request:
I'm working on v2 of SymfonyCasts ResetPasswordBundle && VerifyEmailBundle, I'm planning on introducing generics either in the last 1.x feature release or in the first 2.x release.
Tl;dr, can you split the changes to code that touches make:reset-password and make:registration from this PR into their own PR's here in maker bundle? e.g. [make:reset-password] phpstan types & [make:registration] a good title for the changelog Reasoning: it'll help me over in the symfonycasts repo's and I'll be able to tack on the changes made over there to your 2 new PR's.
Thank you in advance!
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| class <?= $class_name ?> extends ConstraintValidator | |||
| { | |||
| public function validate($value, Constraint $constraint) | |||
| public function validate(mixed $value, Constraint $constraint): void | |||
There was a problem hiding this comment.
I'm not sure if this is possible (e.g. maker has enough knowledge about $value) but can we do string|array<int, mixed>|int|etc..... here instead of mixed? Thinking about phpstan level 9? where it complains if something is mixed or if an array does not define its shape.
I'm not suggesting we do all potential types as a union, but if we know $value could be say, either a string or a int - we should use string|int as the type instead of mixed.
else mixed is perfectly fine here 😉
| 'getPassword', | ||
| 'string', | ||
| '?string', | ||
| true, | ||
| [ | ||
| 'This method can be removed in Symfony 6.0 - is not needed for apps that do not check user passwords.', |
There was a problem hiding this comment.
Do we even need to add this method anymore? I'm just looking at the comment that we add - maker only supports symfony 6.4+
If we do not need the method - lets leave this alone and remove the method in a separate PR.
|
Closed in favor of other PRs I just created. |
Hi,
I have add types for PHPStan for:
make:webhookmake:crudmake:messagemake:registration-formmake:validatormake:reset-passwordWhat do you think ?