Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make:stimulus-controller] more typehints #1506

Merged
merged 1 commit into from
Apr 5, 2024
Merged

[make:stimulus-controller] more typehints #1506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Maker/MakeStimulusController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
]);
}

/** @param string[] $targets */
private function askForNextTarget(ConsoleStyle $io, array $targets, bool $isFirstTarget): ?string
{
$questionText = 'New target name (press <return> to stop adding targets)';
Expand All @@ -150,6 +151,11 @@ private function askForNextTarget(ConsoleStyle $io, array $targets, bool $isFirs
return !$targetName ? null : $targetName;
}

/**
* @param array<string, array<string, string>> $values
*
* @return array<string, string>|null
*/
private function askForNextValue(ConsoleStyle $io, array $values, bool $isFirstValue): ?array
{
$questionText = 'New value name (press <return> to stop adding values)';
Expand Down Expand Up @@ -215,6 +221,7 @@ private function printAvailableTypes(ConsoleStyle $io): void
}
}

/** @return string[] */
private function getValuesTypes(): array
{
return [
Expand Down
Loading