Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make:*] additional type improvements #1502

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Apr 2, 2024

Adds DocBlock type hints to:

final non-@internal classes shown below

AbstractMaker

+    /** @param array<class-string, string> $dependencies */
     protected function addDependencies(array $dependencies, ?string $message = null): string

MakeListener

+   /** @return void */
    public function configureDependencies(DependencyBuilder $dependencies)

MakeMigration

+    /** @return void */
     public function setApplication(Application $application)

    ...

+    /** @return void|int */
     public function generate(InputInterface $input, ConsoleStyle $io, Generator $generator)

MakeTest

+    * @return string[]
     */
     public static function getCommandAliases(): iterable

refs #1498

@jrushlow jrushlow added the Feature New Feature label Apr 2, 2024
@jrushlow jrushlow force-pushed the feature/more-type-fixes branch from 6c55d3f to bec2fbd Compare April 2, 2024 23:19
@jrushlow jrushlow merged commit 2564804 into symfony:main Apr 5, 2024
6 checks passed
@jrushlow jrushlow deleted the feature/more-type-fixes branch April 5, 2024 14:11
@jrushlow jrushlow mentioned this pull request Apr 5, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant