Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - [ci] housekeeping #1269

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 5 additions & 46 deletions .github/workflows/ci.yaml → .github/workflows/phpunit.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "CI"
name: PHPUnit

on:
pull_request:
Expand All @@ -13,53 +13,10 @@ env:
SYMFONY_PHPUNIT_DIR: "$HOME/symfony-bridge/.phpunit"

jobs:
coding-standards:
name: "Coding Standards (${{ matrix.php-version }})"

runs-on: "ubuntu-18.04"

strategy:
fail-fast: false
matrix:
php-version:
- '8.0'

steps:
-
name: "Checkout code"
uses: "actions/checkout@v2"

-
name: "Install PHP"
uses: "shivammathur/setup-php@v2"
with:
coverage: "none"
php-version: "${{ matrix.php-version }}"

-
name: "Validate composer.json"
run: "composer validate --strict --no-check-lock"

-
name: "Composer install"
uses: "ramsey/composer-install@v1"
with:
composer-options: "--no-scripts"

-
name: "Composer install php-cs-fixer"
uses: "ramsey/composer-install@v1"
with:
composer-options: "--no-scripts --working-dir=tools/php-cs-fixer"

-
name: "Run friendsofphp/php-cs-fixer"
run: "tools/php-cs-fixer/vendor/bin/php-cs-fixer fix --dry-run --diff"

test:
name: "PHP ${{ matrix.php-version }} + @${{ matrix.symfony-version }} ${{ matrix.dependency-versions }} deps"
name: "${{ matrix.php-version }} + @${{ matrix.symfony-version }} ${{ matrix.dependency-versions }} deps"

runs-on: ubuntu-18.04
runs-on: ubuntu-latest

services:
mysql:
Expand Down Expand Up @@ -91,12 +48,14 @@ jobs:
matrix:
php-version:
- '8.1'
- '8.2'
symfony-version:
- '5.4.*'
- '5.4.x-dev'
- '6.0.x-dev'
- '6.1.x-dev'
- '6.2.x-dev'
- '6.3.x-dev'
dependency-versions: ['highest']
allow-dev-deps-in-apps: ['0']
include:
Expand Down
39 changes: 39 additions & 0 deletions .github/workflows/static.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
name: Static
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I would name this here CI, because static is a bit misleading, even s prefix in GuthubActions below the PR


on:
push:
branches:
- main
pull_request:
release:
schedule:
- cron: '0 0 * * *'

jobs:
composer-validate:
name: Validate composer.json
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Validate
run: composer validate --strict --no-check-lock

php-cs-fixer:
name: PHP-CS-Fixer
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.1'
tools: php-cs-fixer

- name: Style Check
run: php-cs-fixer fix --dry-run --diff
6 changes: 3 additions & 3 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,6 @@ install:
- composer install --no-interaction --no-progress --ansi --no-scripts --working-dir=tools/php-cs-fixer
- vendor/bin/simple-phpunit install

test_script:
- cd C:\projects\maker-bundle
- vendor/bin/simple-phpunit
#test_script:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO - Enable Tests!

# - cd C:\projects\maker-bundle
# - vendor/bin/simple-phpunit