fixed test name + added suggested change to add type to EntityRelatio…

…n::joinTableName
symfony · Jan 7, 2024 · f4eda5a · f4eda5a
1 parent 5abc8c2
commit f4eda5a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Doctrine/EntityRelation.php b/src/Doctrine/EntityRelation.php
@@ -27,7 +27,7 @@ final class EntityRelation
     private bool $isSelfReferencing = false;
     private bool $orphanRemoval = false;
     private bool $mapInverseRelation = true;
-    private $joinTableName;
+    private ?string $joinTableName;
 
     public function __construct(
         private string $type,

diff --git a/tests/Maker/MakeEntityTest.php b/tests/Maker/MakeEntityTest.php
@@ -311,7 +311,7 @@ public function getTestDetails(): \Generator
                     '',
                 ]);
 
-                $this->runCustomTest($runner, 'it_adds_many_to_many_simple.php');
+                $this->runCustomTest($runner, 'it_adds_many_to_many_with_custom_join_table.php');
             }),
         ];
-Original file line number
+Diff line change
@@ Expand Up / @@ -311,7 +311,7 @@ public function getTestDetails(): \Generator @@
                         '',
                     ]);
-                    $this->runCustomTest($runner, 'it_adds_many_to_many_simple.php');
+                    $this->runCustomTest($runner, 'it_adds_many_to_many_with_custom_join_table.php');
                 }),
             ];
@@ Expand Down @@