[tests] add missing return types

symfony · Apr 2, 2024 · dd34699 · dd34699
1 parent 5fba2ee
commit dd34699
Show file tree

Hide file tree

Showing 10 changed files with 13 additions and 12 deletions.
diff --git a/tests/Maker/FunctionalTest.php b/tests/Maker/FunctionalTest.php
@@ -24,7 +24,7 @@ class FunctionalTest extends TestCase
      * Smoke test to make sure the DI autowiring works and all makers
      * are registered and have the correct arguments.
      */
-    public function testWiring()
+    public function testWiring(): void
     {
         $kernel = new MakerTestKernel('dev', true);
 

diff --git a/tests/Maker/MakeEntityTest.php b/tests/Maker/MakeEntityTest.php
@@ -673,6 +673,7 @@ public function getTestDetails(): \Generator
         ];
     }
 
+    /** @param array<string, mixed> $data */
     private function runEntityTest(MakerTestRunner $runner, array $data = []): void
     {
         $runner->renderTemplateFile(

diff --git a/tests/Maker/MakeFormTest.php b/tests/Maker/MakeFormTest.php
@@ -22,7 +22,7 @@ protected function getMakerClass(): string
         return MakeForm::class;
     }
 
-    public function getTestDetails()
+    public function getTestDetails(): \Generator
     {
         yield 'it_generates_basic_form' => [$this->createMakerTest()
             ->run(function (MakerTestRunner $runner) {
@@ -204,7 +204,7 @@ public function getTestDetails()
         ];
     }
 
-    private function runFormTest(MakerTestRunner $runner, string $filename)
+    private function runFormTest(MakerTestRunner $runner, string $filename): void
     {
         $runner->copy(
             'make-form/tests/'.$filename,

diff --git a/tests/Maker/MakeMessageTest.php b/tests/Maker/MakeMessageTest.php
@@ -40,7 +40,7 @@ private function createMakeMessageTest(): MakerTestDetails
             });
     }
 
-    public function getTestDetails()
+    public function getTestDetails(): \Generator
     {
         yield 'it_generates_basic_message' => [$this->createMakeMessageTest()
             ->run(function (MakerTestRunner $runner) {
@@ -94,7 +94,7 @@ public function getTestDetails()
         ];
     }
 
-    private function runMessageTest(MakerTestRunner $runner, string $filename)
+    private function runMessageTest(MakerTestRunner $runner, string $filename): void
     {
         $runner->copy(
             'make-message/tests/'.$filename,
@@ -104,7 +104,7 @@ private function runMessageTest(MakerTestRunner $runner, string $filename)
         $runner->runTests();
     }
 
-    private function configureTransports(MakerTestRunner $runner)
+    private function configureTransports(MakerTestRunner $runner): void
     {
         $runner->writeFile(
             'config/packages/messenger.yaml',

diff --git a/tests/Maker/MakeMessengerMiddlewareTest.php b/tests/Maker/MakeMessengerMiddlewareTest.php
@@ -22,7 +22,7 @@ protected function getMakerClass(): string
         return MakeMessengerMiddleware::class;
     }
 
-    public function getTestDetails()
+    public function getTestDetails(): \Generator
     {
         yield 'it_generates_messenger_middleware' => [$this->createMakerTest()
             ->run(function (MakerTestRunner $runner) {

diff --git a/tests/Maker/MakeSerializerEncoderTest.php b/tests/Maker/MakeSerializerEncoderTest.php
@@ -22,7 +22,7 @@ protected function getMakerClass(): string
         return MakeSerializerEncoder::class;
     }
 
-    public function getTestDetails()
+    public function getTestDetails(): \Generator
     {
         yield 'it_makes_serializer_encoder' => [$this->createMakerTest()
             // serializer-pack 1.1 requires symfony/property-info >= 5.4

diff --git a/tests/Maker/MakeTwigExtensionTest.php b/tests/Maker/MakeTwigExtensionTest.php
@@ -22,7 +22,7 @@ protected function getMakerClass(): string
         return MakeTwigExtension::class;
     }
 
-    public function getTestDetails()
+    public function getTestDetails(): \Generator
     {
         yield 'it_makes_twig_extension' => [$this->createMakerTest()
             ->run(function (MakerTestRunner $runner) {

diff --git a/tests/Maker/MakeUnitTestTest.php b/tests/Maker/MakeUnitTestTest.php
@@ -25,7 +25,7 @@ protected function getMakerClass(): string
         return MakeUnitTest::class;
     }
 
-    public function getTestDetails()
+    public function getTestDetails(): \Generator
     {
         yield 'it_makes_unit_test' => [$this->createMakerTest()
             ->run(function (MakerTestRunner $runner) {

diff --git a/tests/Maker/MakeValidatorTest.php b/tests/Maker/MakeValidatorTest.php
@@ -22,7 +22,7 @@ protected function getMakerClass(): string
         return MakeValidator::class;
     }
 
-    public function getTestDetails()
+    public function getTestDetails(): \Generator
     {
         yield 'it_makes_validator' => [$this->createMakerTest()
             ->run(function (MakerTestRunner $runner) {

diff --git a/tests/Maker/MakeVoterTest.php b/tests/Maker/MakeVoterTest.php
@@ -22,7 +22,7 @@ protected function getMakerClass(): string
         return MakeVoter::class;
     }
 
-    public function getTestDetails()
+    public function getTestDetails(): \Generator
     {
         yield 'it_makes_voter' => [$this->createMakerTest()
             ->run(function (MakerTestRunner $runner) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -673,6 +673,7 @@ public function getTestDetails(): \Generator @@
             ];
         }
+        /** @param array<string, mixed> $data */
         private function runEntityTest(MakerTestRunner $runner, array $data = []): void
         {
             $runner->renderTemplateFile(
@@ Expand Down @@