Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real composer scripts #930

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

Conversation

morawskim
Copy link

This PR closes #901

At the moment in recipe we can use composer-scripts, but those commands will be running only during composer install or composer update.

This PR adds a new configuration option composer-commands.
We can add to recipe:

.....
"composer-commands": {
    "command": "vendor/bin/foo"
}

and flex will add to composer.json necessary entry and we will able to call composer run command to execute vendor/bin/foo.

This behavior is very similar to current Makefile configurator as mentioned in #901.

@morawskim
Copy link
Author

I will fix the build "PHP 7.4 low-deps" at weekend.

@morawskim morawskim force-pushed the composer-commands branch from ace28cc to 3bc44a3 Compare June 10, 2022 15:52
@morawskim morawskim force-pushed the composer-commands branch from 3bc44a3 to ad92e20 Compare June 10, 2022 15:55
Copy link

@alamirault alamirault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I also need to add commands to script section. I hope it can be merged.

README should probably be updated to document the nex configurator (In another PR ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Real composer scripts
3 participants