fix jsonPath in ComposerScriptsConfigurator::update #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
suggested changes
May 3, 2024
| @@ -49,7 +50,7 @@ public function unconfigure(Recipe $recipe, $scripts, Lock $lock) | |||
| public function update(RecipeUpdate $recipeUpdate, array $originalConfig, array $newConfig): void | |||
| { | |||
| $json = new JsonFile(Factory::getComposerFile()); | |||
| $jsonPath = ltrim(str_replace($recipeUpdate->getRootDir(), '', $json->getPath()), '/\\'); | |||
| $jsonPath = Path::makeRelative($json->getPath(), $recipeUpdate->getRootDir()); | |||
There was a problem hiding this comment.
Flex has no dependencies other than composer-plugin-api, so it is not possible to use an external package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1010
flex/src/Configurator/ComposerScriptsConfigurator.php
Line 52 in bec213c
In case when root dir = ".", it replaces the dot in filename, and then applying the patch is broken with:
Change to using Path::makeRelative for proper result.