Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibis.iSDM submission #35

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

Martin-Jung
Copy link
Collaborator

Quick responses to submission flags in the yaml. For further explanation and details see the package website and in particular the vignettes.

flag Response Comment
occ_acquisition no Left to the user
occ_cleaning yes The package contains some helper functions for preparing biodiversity data including thinning (vignette).
data_integration yes Several approaches for integrating information are provided, including joint integration of different data types (vignette)
env_collinearity yes Range of options from collinear to Boruta application. See train
env_process yes The package contains some helper functions for preparing predictor data including the creation of derivates (vignette).
bias yes Options available via add_bias_control() or add_offset_bias()
study_region yes Key step for any model inference (vignette)
backg_sample yes Range of options available via pseudoabs_settings()
data_partitioning no Currently not implemented and has to be taken care by the user separately.
mod_fit yes Easily supported via train() (train).
mod_tuning yes Parameter option in train() and supported for most engines train.
mod_ensemble yes Call ensemble() on any number of fitted models
mod_stack yes Can easily be accomplished through summing outputs from a fitted model (mod$get_data()).
mod_evaluate yes Call validate() on any trained model with independent data.
mod_multispecies no Not yet supported, specific rank responses might be added in future versions for some engines.
mod_mechanistic yes Several wrappers for mechanistic species distribution models have been added.
pred_general yes Spatial and Spatial-temporal projections are fully supported through dedicated scenario() functions (vignette).
pred_extrapolation yes Functions for assessing similarity surfaces of covariates (similarity()) and limiting factors (limiting()) for future projections are supported.
limitingpred_inspect yes A range of different functions are supported to summarize model outputs and variable importance, including summary(), effects(), partial() and spartial() (reference)
post_processing yes Wide variety of options available to constrain projections (add_constraint()) smooth projections (see parameters in project()).
gui no Not planned
metadata yes A dedicated function that records model input and output parameters has been added (write_summary()).

@sylvainschmitt
Copy link
Owner

@Martin-Jung thanks for your submission. Your metadata check the one on CRAN. I will now seek reviewers for the other fields.

@sylvainschmitt
Copy link
Owner

@adamlilith
Copy link
Collaborator

adamlilith commented Oct 3, 2023 via email

Copy link
Collaborator

@hannahlowens hannahlowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the careful work.

@sylvainschmitt
Copy link
Owner

Looks great! Thanks for the careful work.

Thanks for the review @hannahlowens

@sylvainschmitt
Copy link
Owner

Hey Sylvain, I’d be happy to do this. However, I recall I wasn’t sure how to use GitHub in the manner that you’d need for a review. Would you be able to meet with me online and show me how? I expect that there will be future reviews required once we get our paper published!

Hi @adamlilith , sorry I was not available last week but I am now. We can schedule a visio. However, I think I should note the information that helped you and start a collaborative wiki to help authors, reviewers, and editors.

@jamiemkass
Copy link
Collaborator

Hey folks, this PR was left hanging. Any updates?

@sylvainschmitt
Copy link
Owner

Hey folks, this PR was left hanging. Any updates?

Sorry @Martin-Jung , my bad I totally forgot. Maybe we should have several editors to avoid that. Based on @hannahlowens I will accept the submission.

@sylvainschmitt
Copy link
Owner

@Martin-Jung , thanks for the submission of ibis.iSDM. Your contribution can be integrated without further edits. After merging your pull request, you will be added to the repository contributors. Please expect to be contacted for a review request in the future.

@sylvainschmitt sylvainschmitt merged commit 0dc4bf6 into sylvainschmitt:main Apr 9, 2024
1 of 4 checks passed
@Martin-Jung
Copy link
Collaborator Author

Thanks a lot, happy to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants