Gitignore for IntelliJ and some small cleanups #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! I am not aware of the cleanup feature on IntelliJ, but I do like the ones introduced in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just started to look into the code with IntelliJ and did some small cleanups, and added entries to the gitignore. The cleanups were mostly applied automatically by IntelliJ.
There are much more cleanups IntelliJ suggested to do but I leave it at this for now. I'm not sure if you are interested in such cleanups.
I started to look into the code to make it work for my PhD thesis. Unfortunately it looks to me that the current design seems to require a major rewrite to support Latex commands spanning over multiple lines (#174). So I will stop working on this for now, until I see a clear path forward how to proceed fixing this. But this is all off-topic for this PR.