Refactors in configuration-layer #16351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcc32
force-pushed
the
preparatory-refactors-in-configuration-layer
branch
from
a008518 to
7dc6553
Compare
string< can be used directly with symbols.
This makes its calling convention consistent with cfgl-package-enabled-p and so on.
This should have no real behavior change, except that the predicate functions may not be called on all elements of the input list if it returns nil on an earlier one.
bcc32
force-pushed
the
preparatory-refactors-in-configuration-layer
branch
from
7dc6553 to
fca0b53
Compare
smile13241324
approved these changes
May 11, 2024
2ynn
pushed a commit
to 2ynn/spacemacs
that referenced
this pull request
Jul 8, 2024
* [configuration-layer] Simplify configuration-layer//sort-packages string< can be used directly with symbols. * [configuration-layer] Simplify configuration-layer//filter-objects * cfgl-package-used-p: Add inhibit-messages argument This makes its calling convention consistent with cfgl-package-enabled-p and so on. * [core-configuration-layer] Refactor to use cl-every This should have no real behavior change, except that the predicate functions may not be called on all elements of the input list if it returns nil on an earlier one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just contains some behavior-preserving refactors in
core-configuration-layer.el, as part of preparing to address #16346.